Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full DSL for non-sandboxed PR runs #439

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Jul 9, 2019

This fixes #367.

Currently, the full DSL is not used for non-sandboxed PR runs. This fixes that by calling the existing createPRDSL function and providing the GH access token so the API can be authenticated.

This was not a problem for sandboxed runs since guthub.api and github.utils are recreated in appendPerilContextToDSL.

@vercel
Copy link

vercel bot commented Jul 9, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@orta
Copy link
Member

orta commented Jul 9, 2019

Nice one!

@orta orta merged commit e37ded5 into danger:master Jul 9, 2019
@jtreanor jtreanor deleted the fix-pr-dsl branch July 9, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting 'TypeError: danger.git.JSONDiffForFile is not a function'
2 participants